yin1999 commented on code in PR #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136#discussion_r1441213789


##########
generate/templates/main.go:
##########
@@ -61,7 +64,7 @@ func main() {
        if err != nil {
                log.Fatal(err)
        }
-       _, err = fmt.Fprintln(srcOut, "// Code generated by go generate; DO NOT 
EDIT.\npackage generate\n\nvar TemplatesZip = []byte{")
+       _, err = fmt.Fprint(srcOut, "// Code generated by go generate; DO NOT 
EDIT.\npackage generate\n\nvar TemplatesZip = []byte{")

Review Comment:
   this previous function call left a empty line before the bytes array



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to