sjmshsh commented on PR #134: URL: https://github.com/apache/dubbo-kubernetes/pull/134#issuecomment-1884663167
> ## What is the purpose of the change > support containers-auth.json, part of: #93 > > ## How to verify this change > Verified `dubboctl` can correctly read the auth information from the `auth.json` which is stored without [credential helper](https://github.com/docker/docker-credential-helpers). Tested on Debian testing and Windows 10. > > Linux testing (with `DOCKER_HOST="unix://${XDG_RUNTIME_DIR}/podman/podman.sock"` env set): > >  > > Windows testing ([installation guide](https://github.com/containers/podman/blob/main/docs/tutorials/podman-for-windows.md)): > >  > > Other tests we can do in the future: > > * test with the [credential helper](https://github.com/docker/docker-credential-helpers), currently, podman does not support credential helper with rootless mode. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
