AlbumenJ commented on code in PR #13607:
URL: https://github.com/apache/dubbo/pull/13607#discussion_r1451120372
##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/LRU2Cache.java:
##########
@@ -19,22 +19,23 @@
import java.util.LinkedHashMap;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
+import java.util.function.Function;
/**
* LRU-2
- * </p>
+ * <p>
* When the data accessed for the first time, add it to history list. If the
size of history list reaches max capacity, eliminate the earliest data (first
in first out).
* When the data already exists in the history list, and be accessed for the
second time, then it will be put into cache.
- *
+ * </p>
* TODO, consider replacing with ConcurrentHashMap to improve performance
under concurrency
*/
public class LRU2Cache<K, V> extends LinkedHashMap<K, V> {
Review Comment:
LRU2Cache 和 LRUCache 历史上存在过并发或者是内存泄漏问题，如果需要使用的话这部分需要验证下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
