chickenlj commented on code in PR #13644:
URL: https://github.com/apache/dubbo/pull/13644#discussion_r1452045164
##########
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataService.java:
##########
Review Comment:
I think so. The service definition is as shown below:
```protobuf
package org.apache.dubbo.metadata;
option go_package = "dubbo.apache.org/dubbo-go/v3/metadata/triple_api";
option java_package = "org.apache.dubbo.metadata";
option java_multiple_files = true;
```
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ConfigurableMetadataServiceExporter.java:
##########
@@ -65,13 +66,12 @@ public synchronized ConfigurableMetadataServiceExporter
export() {
.getInternalServiceExecutor();
this.serviceConfig =
InternalServiceConfigBuilder.<MetadataService>newBuilder(applicationModel)
.interfaceClass(MetadataService.class)
-
.protocol(getApplicationConfig().getMetadataServiceProtocol(),
METADATA_SERVICE_PROTOCOL_KEY)
+ .protocol(TRIPLE, METADATA_SERVICE_PROTOCOL_KEY)
Review Comment:
> Yes. I will do some refactor later to make sure it can compatible with
older version.
I think it's desired to only support triple protocol in the new release. But
we need to guarantee compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
