oxsean commented on code in PR #13607:
URL: https://github.com/apache/dubbo/pull/13607#discussion_r1457015318
##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/TimeUtils.java:
##########
@@ -73,4 +73,29 @@ private static synchronized void startTicker() {
isTickerAlive = true;
}
}
+
+ public static Long parseTimeoutToMills(String timeoutVal) {
Review Comment:
LRU2Cache has been updated with overwrite 'computeIfAbsent' method. This
wasn't overridden before, and using it could lead to concurrency issues due to
the lack of locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
