AlbumenJ commented on code in PR #13781:
URL: https://github.com/apache/dubbo/pull/13781#discussion_r1500250141
##########
dubbo-common/src/main/java/org/apache/dubbo/common/config/ModuleEnvironment.java:
##########
@@ -93,9 +93,6 @@ public List<Map<String, String>>
getConfigurationMaps(AbstractConfig config, Str
@Override
public Configuration getDynamicGlobalConfiguration() {
- if (dynamicConfiguration == null) {
- return applicationDelegate.getDynamicGlobalConfiguration();
- }
Review Comment:
Should support use applicationModel's dynamic configuration if not set to
ModelEnvironment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
