finefuture commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1506934467
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/RequestMetadata.java:
##########
@@ -57,7 +57,8 @@ public DefaultHttp2Headers toHeaders() {
.method(HttpMethod.POST.asciiName())
.path("/" + service + "/" + method.getMethodName())
.set(TripleHeaderEnum.CONTENT_TYPE_KEY.getHeader(),
MediaType.APPLICATION_GRPC_PROTO.getName())
- .set(HttpHeaderNames.TE, HttpHeaderValues.TRAILERS);
+ .set(HttpHeaderNames.TE, HttpHeaderValues.TRAILERS)
+ .set(TripleHeaderEnum.TRI_PARAM_DESC.getHeader(),
method.getParamDesc());
Review Comment:
This is not necessary, it is an optional field, and I will remove it and
find other ways to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
