FinalT commented on code in PR #2601:
URL: https://github.com/apache/dubbo-go/pull/2601#discussion_r1512346339
##########
cluster/cluster/failover/cluster_test.go:
##########
@@ -95,6 +92,19 @@ func TestFailoverInvoke2(t *testing.T) {
clusterpkg.Count = 0
}
+// nolint
+// Test call retries opt
Review Comment:
I think we should indicate this is a attachment retry test
##########
cluster/cluster/failover/cluster_invoker.go:
##########
@@ -20,6 +20,7 @@ package failover
import (
"context"
"fmt"
+ "strconv"
"github.com/dubbogo/gost/log/logger"
perrors "github.com/pkg/errors"
Review Comment:
ditto.
##########
cluster/cluster/failover/cluster_test.go:
##########
@@ -84,7 +80,8 @@ func TestFailoverInvoke1(t *testing.T) {
}
// nolint
-func TestFailoverInvoke2(t *testing.T) {
+// Test client retries opt
Review Comment:
I think we should indicate this is a method retries test
##########
cluster/cluster/failback/cluster_invoker.go:
##########
@@ -22,21 +22,15 @@ import (
"strconv"
"sync"
"time"
-)
-
-import (
- "github.com/Workiva/go-datastructures/queue"
-
- "github.com/dubbogo/gost/log/logger"
-)
-import (
"dubbo.apache.org/dubbo-go/v3/cluster/cluster/base"
"dubbo.apache.org/dubbo-go/v3/cluster/directory"
"dubbo.apache.org/dubbo-go/v3/cluster/loadbalance"
"dubbo.apache.org/dubbo-go/v3/common/constant"
"dubbo.apache.org/dubbo-go/v3/common/extension"
"dubbo.apache.org/dubbo-go/v3/protocol"
+ "github.com/Workiva/go-datastructures/queue"
+ "github.com/dubbogo/gost/log/logger"
Review Comment:
Plz use [tools](https://github.com/dubbogo/tools) to format imports
##########
cluster/cluster/failover/cluster_test.go:
##########
@@ -22,13 +22,7 @@ import (
"fmt"
"net/url"
"testing"
-)
-
-import (
- "github.com/stretchr/testify/assert"
-)
-import (
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
