oxsean commented on code in PR #13818:
URL: https://github.com/apache/dubbo/pull/13818#discussion_r1511219681
##########
dubbo-demo/dubbo-demo-spring-boot/dubbo-demo-spring-boot-consumer/pom.xml:
##########
@@ -101,6 +101,12 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
+ <exclusions>
Review Comment:
I think it's unnecessary because we already excluded the artifact in:
https://github.com/apache/dubbo/blob/3.3/dubbo-demo/dubbo-demo-spring-boot/pom.xml#L50
##########
dubbo-spring-boot/dubbo-spring-boot-starters/observability/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/observability/autoconfigure/otel/OpenTelemetryAutoConfiguration.java:
##########
@@ -62,15 +62,12 @@ public class OpenTelemetryAutoConfiguration {
/**
* Default value for application name if {@code spring.application.name}
is not set.
*/
- private static final String DEFAULT_APPLICATION_NAME = "application";
+ private static final String DEFAULT_APPLICATION_NAME =
"unknown_dubbo_service";
private final DubboConfigurationProperties dubboConfigProperties;
Review Comment:
From the comments in DubboConfigurationProperties, it seems that
DubboConfigurationProperties is only used to generate JSON metadata.
##########
dubbo-demo/dubbo-demo-spring-boot/dubbo-demo-spring-boot-provider/pom.xml:
##########
@@ -101,6 +101,12 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
+ <exclusions>
Review Comment:
Ditto, unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
