aofall commented on code in PR #13923:
URL: https://github.com/apache/dubbo/pull/13923#discussion_r1526397930
##########
dubbo-filter/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/support/jvalidation/JValidation.java:
##########
@@ -28,12 +31,24 @@
public class JValidation extends AbstractValidation {
/**
- * Return new instance of {@link JValidator}
+ * Return new instance of {@link Validator}
* @param url Valid URL instance
- * @return Instance of JValidator
+ * @return Instance of Validator
*/
@Override
protected Validator createValidator(URL url) {
- return new JValidator(url);
+ List<Class<? extends Validator>> validatorList =
Arrays.asList(JValidator.class, JValidatorNew.class);
Review Comment:
Did you meaning loading `JValidator.class` and `JValidatorNew.class` classes
with `Class.forName(String)` like this? Or could you please provided more
detail info
```
try {
Class<? extends Validator> validCls = (Class<? extends Validator>)
Class.forName("org.apache.dubbo.validation.support.jvalidation.JValidator");
Class<? extends Validator> newValidCls = (Class<? extends Validator>)
Class.forName("org.apache.dubbo.validation.support.jvalidation.JValidatorNew");
} catch (Throwable ignore) {
}
```
By the way, the `JValidator.java#316` and `JValidatorNew.java#316` need to
be modified together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
