kwsc98 commented on code in PR #184:
URL: https://github.com/apache/dubbo-rust/pull/184#discussion_r1527477678
##########
dubbo/src/extension/mod.rs:
##########
@@ -89,47 +87,134 @@ impl ExtensionDirectory {
ExtensionType::Registry => match extension_factories {
ExtensionFactories::RegistryExtensionFactory(registry_extension_factory) => {
self.registry_extension_loader
- .register(extension_name, registry_extension_factory)
- .await;
+ .register(extension_name, registry_extension_factory);
Ok(())
}
},
}
}
- async fn remove(
+ fn remove(
&mut self,
extension_name: String,
extension_type: ExtensionType,
) -> Result<(), StdError> {
match extension_type {
ExtensionType::Registry => {
- self.registry_extension_loader.remove(extension_name).await;
+ self.registry_extension_loader.remove(extension_name);
Ok(())
}
}
}
- async fn load(
+ fn load(
&mut self,
url: Url,
extension_type: ExtensionType,
- ) -> Result<Extensions, StdError> {
+ callback: oneshot::Sender<Result<Extensions, StdError>>,
+ ) {
match extension_type {
ExtensionType::Registry => {
- let extension =
self.registry_extension_loader.load(&url).await;
+ let extension = self.registry_extension_loader.load(url);
match extension {
- Ok(extension) => Ok(Extensions::Registry(extension)),
+ Ok(mut extension) => {
+ tokio::spawn(async move {
+ let extension = extension.resolve().await;
+ match extension {
+ Ok(extension) => {
+ let _ =
callback.send(Ok(Extensions::Registry(extension)));
+ }
+ Err(err) => {
+ error!("load extension failed: {}", err);
+ let _ = callback.send(Err(err));
+ }
+ }
+ });
+ }
Err(err) => {
error!("load extension failed: {}", err);
- Err(err)
+ let _ = callback.send(Err(err));
}
}
}
}
}
}
+pub(crate) struct LoadExtensionPromise<T> {
+ extension: Arc<Option<T>>,
Review Comment:
advise maintain a RwLock , Avoid using unsafe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
