finefuture commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2024754788
> I think it would be better to just change the way how `REGISTRY_CLUSTER_KEY` is generated. > > For now, `REGISTRY_CLUSTER_KEY` is the same as `id` (controlled by `@Parameter(key = REGISTRY_CLUSTER_KEY)`). If we want it to include `namespace` in `REGISTRY_CLUSTER_KEY`, we can change the code to make sure that `namespace` is included in `REGISTRY_CLUSTER_KEY` the first time the `registry url` is generated. > > Then the only place we need to change except for the `REGISTRY_CLUSTER_KEY` generating process (to include both id and namespace) is how to map the MetadataReport instance with the `REGISTRY_CLUSTER_KEY`(also to have `namespace` included) https://github.com/apache/dubbo/pull/13971/files#diff-1e44977c9c4b360c444eb20fbc5599acc73533c783c897954e068e88ab339278R117. Ok, I will try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
