AlbumenJ commented on issue #13963:
URL: https://github.com/apache/dubbo/issues/13963#issuecomment-2031192922

   > Before I start, I have some questions about this issue:
   > 
   > * Check all the types that Dubbo can support: I guess the current 
JsonCompatibilityUtil already has the functionality to check the compatibility 
of classes. Is it the same usage as JsonCompatibilityUtil in RestProtocol, and 
should we also use JsonCompatibilityUtil to do the same thing in TripleProtocol?
   > 
   > ```java
   > // this is the JsonCompatibilityUtil in RestProtocol
   > private void checkJsonCompatibility(Class<?> clazz, String jsonCheckLevel) 
throws RpcException {
   > 
   >         if (jsonCheckLevel == null || 
JSON_CHECK_LEVEL_WARN.equals(jsonCheckLevel)) {
   >         //....
   >         List<String> unsupportedMethods = 
JsonCompatibilityUtil.getUnsupportedMethods(clazz);
   >         } else if (JSON_CHECK_LEVEL_STRICT.equals(jsonCheckLevel)) {
   >         // ...
   >         }
   >     }
   > ```
   > 
   > * Generate the demo json struct: Does JsonCompatibilityUtil need to 
generate corresponding sample JSON structures based on interface parameters 
during the validation process?
   
   - In TripleProtocol
   - No. This is a explict feature. @oxsean Do you have any ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to