Stellar1999 commented on code in PR #14028:
URL: https://github.com/apache/dubbo/pull/14028#discussion_r1555439914
##########
dubbo-remoting/dubbo-remoting-zookeeper-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperTransporter.java:
##########
@@ -27,16 +27,14 @@ public interface ZookeeperTransporter {
String CURATOR_5 = "curator5";
- String CURATOR = "curator";
-
ZookeeperClient connect(URL url);
void destroy();
static ZookeeperTransporter getExtension(ApplicationModel
applicationModel) {
ExtensionLoader<ZookeeperTransporter> extensionLoader =
applicationModel.getExtensionLoader(ZookeeperTransporter.class);
- return isHighVersionCurator() ?
extensionLoader.getExtension(CURATOR_5) : extensionLoader.getExtension(CURATOR);
+ return extensionLoader.getExtension(CURATOR_5);
Review Comment:
Please take another look. Do you think my code is correct? I removed the SPI
and moved the ZookeeperTransporter to the module
`dubbo-remoting-zookeeper-curator5` in order to create an instance of
Curator5ZookeeperTransporter. @CrazyHZM Thanks for your code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
