CrazyHZM commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556764092
##########
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##########
@@ -13,15 +13,17 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Specify the application name of Dubbo
-dubbo.application.name=extensibility-protocol-provider
-
-# Enable token verification for each invocation
-dubbo.provider.token=true
-
-# Specify the registry address
-dubbo.registry.address=nacos://localhost:8848?username=nacos&password=nacos
-#
dubbo.registry.address=nacos://${nacos.address:localhost}:8848?username=nacos&password=nacos
-
-# Specify the port of eDubbo protocol
-dubbo.provider.protocol=edubbo
Review Comment:
Please let me know why this config is missing. This configuration is a
sample of core content. Please check all the changes.
##########
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##########
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+dubbo:
+ application:
+ # Specify the application name of Dubbo
+ name: extensibility-filter-provider
+ protocol:
+ # Specify the port of Dubbo protocol
+ port: 20881
+ provider:
+ # Apply AppendedFilter
+ filter: appended
+ # Enable token verification for each invocation
+ token: true
+ registry:
+ # Specify the registry address
+ address: nacos://localhost:8848?username=nacos&password=nacos
+# address: nacos://localhost:8848?username=nacos&password=nacos
Review Comment:
Is this configuration file only a new, no-removed properties file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
