FoghostCn commented on code in PR #2661:
URL: https://github.com/apache/dubbo-go/pull/2661#discussion_r1565120242
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -69,7 +69,7 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
Build()).
SetRegistryIDs("N/A").
SetInterface(constant.MetadataServiceName).
- SetGroup(config.GetApplicationConfig().Name).
+ SetGroup(config.GetApplicationConfig().Group).
Review Comment:
So I don't think we should change it
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -69,7 +69,7 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
Build()).
SetRegistryIDs("N/A").
SetInterface(constant.MetadataServiceName).
- SetGroup(config.GetApplicationConfig().Name).
+ SetGroup(config.GetApplicationConfig().Group).
Review Comment:
In the java implementation it also uses the application name as the metadata
group, I don't know why but I think it's not a coincidence
https://github.com/apache/dubbo/blob/155c2f2c186cc797a2f31d9488e66cca07f892c4/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/InternalServiceConfigBuilder.java#L294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
