chickenlj commented on code in PR #14096:
URL: https://github.com/apache/dubbo/pull/14096#discussion_r1574055684
##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java:
##########
@@ -174,18 +182,33 @@ public List<URL> lookup(final URL url) {
public void doRegister(URL url) {
try {
if (PROVIDER_SIDE.equals(url.getSide()) ||
getUrl().getParameter(REGISTER_CONSUMER_URL_KEY, false)) {
- String serviceName = getServiceName(url);
Instance instance = createInstance(url);
+
+ Set<String> serviceNames = new HashSet<>();
+ // by default servicename is
"org.apache.dubbo.xxService:1.0.0:"
+ String serviceName = getServiceName(url, false);
+ serviceNames.add(serviceName);
+
+ // in https://github.com/apache/dubbo/issues/14075
+ if
(Boolean.parseBoolean(DUUBO_NACOS_EXPORT_NOTING_SUFFIX_SERVICENAME)) {
Review Comment:
Please add some unit tests to verify this change. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
