AlbumenJ commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594884669
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##########
@@ -181,4 +153,48 @@ private boolean isSsl(ByteBuf buf) {
}
return false;
}
+
+ private void detectProtocol(ChannelHandlerContext ctx, URL url,
NettyChannel channel, ByteBuf in) {
+ Set<String> supportedProtocolNames = new HashSet<>(protocols.keySet());
+ supportedProtocolNames.retainAll(urlMapper.keySet());
+
+ for (final String name : supportedProtocolNames) {
+ WireProtocol protocol = protocols.get(name);
+ in.markReaderIndex();
+ ChannelBuffer buf = new NettyBackedChannelBuffer(in);
+ final ProtocolDetector.Result result =
protocol.detector().detect(buf);
+ in.resetReaderIndex();
+ switch (result.flag()) {
+ case UNRECOGNIZED:
+ continue;
+ case RECOGNIZED:
+ ChannelHandler localHandler =
this.handlerMapper.getOrDefault(name, handler);
+ URL localURL = this.urlMapper.getOrDefault(name, url);
+ channel.setUrl(localURL);
+ NettyConfigOperator operator = new
NettyConfigOperator(channel, localHandler);
+ operator.setDetectResult(result);
+ protocol.configServerProtocolHandler(url, operator);
+ ctx.pipeline().remove(this);
+ case NEED_MORE_DATA:
+ return;
+ default:
+ return;
+ }
+ }
+ byte[] preface = new byte[in.readableBytes()];
+ in.readBytes(preface);
+ Set<String> supported =
Review Comment:
Should cache this object in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
