oxsean commented on code in PR #14077:
URL: https://github.com/apache/dubbo/pull/14077#discussion_r1604287940
##########
dubbo-common/src/main/java/org/apache/dubbo/config/ProtocolConfig.java:
##########
@@ -236,6 +238,9 @@ public class ProtocolConfig extends AbstractConfig {
*/
private String jsonCheckLevel;
+ @Nested
+ private TripleConfig triple;
Review Comment:
@finefuture make sense, initialize the default values here can avoid the
null check during in builder.
We can add a checkDefault in TripleConfig add call it in ProtocolConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
