oxsean commented on code in PR #14073:
URL: https://github.com/apache/dubbo/pull/14073#discussion_r1609223477
##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java:
##########
@@ -22,5 +22,5 @@
@SPI(scope = ExtensionScope.FRAMEWORK)
public interface HeaderFilter {
- RpcInvocation invoke(Invoker<?> invoker, RpcInvocation invocation) throws
RpcException;
+ void invoke(Invoker<?> invoker, RpcInvocation invocation) throws
RpcException;
Review Comment:
I didn't notice that this API was introduced in 3.0. indeed shouldn't be
modified, I'll revert it later. However, this return value not being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
