cirth9 opened a new pull request, #292:
URL: https://github.com/apache/dubbo-kubernetes/pull/292

   ## What is the purpose of the chan
   The original approach to get versiongroup int application form interface had 
some flaws. It directly concatenated the two strings with a space in between, 
and then inserted the result into a Set to ensure that the groupVersion 
information was not duplicated. However, this approach had a flaw, for example, 
when one of the strings was an empty string.
   Here, the approach has been changed to serialize a struct to json string.
   
   and then, I have removed some meaningless codes 
   ## CheckList
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to