yin1999 commented on code in PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306#discussion_r1649829774
########## deploy/charts/admin/Chart.yaml: ########## Review Comment: `zookeeper` has been registered by the templates under `deploy/charts/admin/templates/register/zk`. Currently this dependency will result in the existence of multiple zookeeper services. We do not need the additional zookeeper service yet. ########## deploy/charts/admin/values.yaml: ########## @@ -41,7 +52,7 @@ image: # Source of the container image. registry: docker.io/apache/dubbo-admin # Version tag of the container image. - tag: 0.5.0 + tag: latest Review Comment: In fact, we need to push a new image to docker hub. So we still need to update this field in the future. ########## deploy/charts/admin/values.yaml: ########## @@ -74,23 +85,6 @@ volumes: ~ # hostPath: # path: /data -## Define a ConfigMap for the application, You can create a ConfigMap and specify its name, items, and defaultMode. Review Comment: This is used by https://github.com/apache/dubbo-kubernetes/pull/306/files#diff-87a6f011cb6b0df194fb8086ddfa8d1ce8fce2bcf681215c3799b5080b7ce453L131, which is replaced with `controlPlane.config` (check: `deploy/charts/admin/templates/admin/admin-configmap.yaml`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
