Chenjp commented on PR #14091: URL: https://github.com/apache/dubbo/pull/14091#issuecomment-2210291654
> > > The change itself in the refactoring patch is right. The "who creates, who destroys" design introduced is indeed impressive, but I think it's not so demanded in this scenario in which all operations are restricted inside one instance, it can be more useful when need to release or close resources across different components. > > > > > > @chickenlj Thank you for your comments. As mentioned, the change is right, is the PR ready to merged back? > > From the description of this PR, it fixes the following issue `Protect framework-executor from being destroyed by AbstractCacheManager.`. But what I see is only refactor, without any functionality changes, so I need to make sure if there's any bugfix or enhancement there before merging. Functional change: This PR is valuable only when CacheManager's lifecycle is different with Framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
