yin1999 opened a new pull request, #317: URL: https://github.com/apache/dubbo-kubernetes/pull/317
## What is the purpose of the change Part of #48 (may fix it). Considering that creating custom builders will increase maintenance costs, providing a mirror of the general builder (from [Paketo Buildpacks](https://paketo.io/)) for users in mainland China is a lower-cost approach. ## Brief changelog feat(dubboctl): add support for using CN mirror of buildpacks toolchain ## Verifying this change Using the following command to compile and build the `dubboctl` ```bash go build -ldflags='-s -w -buildid=' -trimpath -o bin/dubboctl ./app/dubboctl/ ``` And than using the `dubboctl` command to build a image (create any project of Golang, or Java) with the `dubbo.yaml` config: ```yaml # dubbo.yaml runtime: java # or 'go' for golang project image: test-server:latest created: 2020-03-18T07:32:39.8834Z build: buildEnvs: - name: BP_DEPENDENCY_MIRROR_GITHUB_COM value: mirror.example.com # may provide after we create the github release mirror # Using the CN mirror for builders and lifecycle images cnMirror: true ``` ```bash dubboctl build generate --image test-http-server:latest --push=false --force ``` ## CheckList - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [x] GitHub Actions works fine on your own branch. (may fail due to files not covered by this PR) - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
