chaokunyang commented on code in PR #476:
URL:
https://github.com/apache/dubbo-spi-extensions/pull/476#discussion_r1724316099
##########
dubbo-serialization-extensions/dubbo-serialization-fury/src/main/java/org/apache/dubbo/common/serialize/fury/dubbo/FuryObjectInput.java:
##########
@@ -40,7 +40,7 @@ public FuryObjectInput(Fury fury, MemoryBuffer buffer,
InputStream input) {
@Override
public Object readObject() {
- return fury.deserialize(new FuryInputStream(input, buffer.size()));
+ return fury.deserializeJavaObjectAndClass(new FuryInputStream(input,
buffer.size()));
Review Comment:
Could we use `BlockedStreamUtils.deserialize(fury, output, obj);` and
`BlockedStreamUtils.serialize(fury, output, obj);` instead?
`FuryInputStream` will buffer data internally for speed, which may read more
data than needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
