oxsean commented on code in PR #14390:
URL: https://github.com/apache/dubbo/pull/14390#discussion_r1734166136
##########
dubbo-spring-boot/dubbo-spring-boot-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java:
##########
@@ -35,18 +36,20 @@
@Conditional(SpringBoot12Condition.class)
public class DubboTripleAutoConfiguration {
- public static final String PREFIX = "dubbo.protocol.triple.servlet";
+ public static final String SERVLET_PREFIX =
"dubbo.protocol.triple.servlet";
+
+ public static final String WEBSOCKET_PREFIX =
"dubbo.protocol.triple.websocket";
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(Filter.class)
@ConditionalOnWebApplication(type = Type.SERVLET)
- @ConditionalOnProperty(prefix = PREFIX, name = "enable")
+ @ConditionalOnProperty(prefix = SERVLET_PREFIX, name = "enable")
Review Comment:
Use `enabled` to keep the same wording style as spring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
