wcy666103 commented on code in PR #1188: URL: https://github.com/apache/dubbo-samples/pull/1188#discussion_r1824131423
########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto + +package helloworld; + +// 请求消息,包含用户的名字。 +message HelloRequest { + string name = 1; +} + +// 响应消息,包含问候语。 +message HelloReply { + string message = 1; +} + +// 服务定义,带有自定义 HTTP 映射。 Review Comment: You should remove the Chinese comments or replace them with English comments. ########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto + +package helloworld; + +// 请求消息,包含用户的名字。 +message HelloRequest { + string name = 1; +} + +// 响应消息,包含问候语。 +message HelloReply { + string message = 1; +} + +// 服务定义,带有自定义 HTTP 映射。 +service Greeter { + // 使用 POST 方法测试请求体映射 Review Comment: You should remove the Chinese comments or replace them with English comments. ########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto + +package helloworld; + +// 请求消息,包含用户的名字。 +message HelloRequest { + string name = 1; +} + +// 响应消息,包含问候语。 Review Comment: You should remove the Chinese comments or replace them with English comments. ########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto Review Comment: You should remove the Chinese comments or replace them with English comments. ########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto + +package helloworld; + +// 请求消息,包含用户的名字。 +message HelloRequest { + string name = 1; +} + +// 响应消息,包含问候语。 +message HelloReply { + string message = 1; +} + +// 服务定义,带有自定义 HTTP 映射。 +service Greeter { + // 使用 POST 方法测试请求体映射 + rpc SayHelloWithPost(HelloRequest) returns (HelloReply) { + option (google.api.http) = { + post: "/v1/hello" + body: "*" + }; + } + + // 使用 PUT 方法测试请求体和路径变量映射 Review Comment: You should remove the Chinese comments or replace them with English comments. ########## 2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-custom-uri/src/main/proto/helloworld.proto: ########## @@ -0,0 +1,38 @@ +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.dubbo.custom.uri.demo"; +option java_outer_classname = "HelloWorldProto"; + +import "google/api/annotations.proto"; // 引入 annotations.proto + +package helloworld; + +// 请求消息,包含用户的名字。 Review Comment: You should remove the Chinese comments or replace them with English comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org