strangelookingnerd opened a new pull request, #14922: URL: https://github.com/apache/dubbo/pull/14922
Most of the tests already use JUnit5. This PR will migrate the missing tests and remove the `junit-jupiter-vintage` as well as `junit` dependencies. Migration includes: * Using JUnit5 annotations * Using `Assertions` * Remove `public` modifiers from test classes and methods * Clean up assertions (switching `expected` and `actual`, simplyifing assertions...) * Trivial code cleanup I validated my changes using `./build -t`. ## Checklist - [ ] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](./CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
