oxsean commented on code in PR #14924:
URL: https://github.com/apache/dubbo/pull/14924#discussion_r1875638729


##########
pom.xml:
##########
@@ -160,11 +162,12 @@
     <maven_antrun_version>3.1.0</maven_antrun_version>
     <maven_os_plugin_version>1.7.1</maven_os_plugin_version>
     <maven_protobuf_plugin_version>0.6.1</maven_protobuf_plugin_version>
-    <maven_gmavenplus.version>3.0.2</maven_gmavenplus.version>
+    <maven_gmavenplus_version>3.0.2</maven_gmavenplus_version>
+    <dubbo_maven_version>3.3.2</dubbo_maven_version>

Review Comment:
   Because maven can't use the plugin output when compiling multiple modules, 
it will cause the completion failed for new version, because we just use the 
plugin in the demo and triple modules, so I think it's acceptable to use the 
release version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to