mutezebra commented on code in PR #646: URL: https://github.com/apache/dubbo-go-pixiu/pull/646#discussion_r1903280348
########## pkg/logger/triple.go: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package logger + +// TripleLogger does not add user-defined logger fields so that there is no pointer reference after it is updated +// make all references point to control +type TripleLogger struct { Review Comment: > Why add a TripleLogger? TripleLogger is to implement an interface In the design, we should not allow other places to have a reference to logger in the "control" variable, which allows us to update the logger configuration without changing any references to the logger <img width="1751" alt="image" src="https://github.com/user-attachments/assets/ced8b748-38af-49ae-85a7-e47a7dadfd3f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
