mutezebra commented on code in PR #647: URL: https://github.com/apache/dubbo-go-pixiu/pull/647#discussion_r1921737580
########## configcenter/load.go: ########## @@ -22,7 +22,7 @@ import ( ) import ( - "github.com/ghodss/yaml" + "gopkg.in/yaml.v3" Review Comment: > pls fix reviewdog, Include reviewdog below The `gopkg.in/yaml.v3` package is referenced by `ParseYamlBytes` in lines 136-139 of configcenter/load.go. However, since these changes were not included in the commit, reviewdog flagged an error. In reality, the reference is present in the project. Some of the errors reported by reviewdog are due to the same reason as mentioned earlier, while others are because I added a `.` before the imported packages, allowing the use of package members without a prefix. This is a syntactic sugar in Go, and it is not an `"undeclared name: So (typecheck)"` issue as reported by reviewdog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
