marsevilspirit commented on code in PR #651: URL: https://github.com/apache/dubbo-go-pixiu/pull/651#discussion_r1973074043
########## pkg/adapter/dubboregistry/registry/nacos/application_listener.go: ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package nacos + +import ( + "strings" + "sync" + "time" +) + +import ( + dubboCommon "dubbo.apache.org/dubbo-go/v3/common" + "dubbo.apache.org/dubbo-go/v3/common/constant" + "github.com/nacos-group/nacos-sdk-go/clients/naming_client" + "github.com/nacos-group/nacos-sdk-go/vo" +) + +import ( + common2 "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/common" + "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/registry" + "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/remoting/zookeeper" + "github.com/apache/dubbo-go-pixiu/pkg/logger" + "github.com/apache/dubbo-go-pixiu/pkg/model" +) + +var _ registry.Listener = new(nacosAppListener) + +type nacosAppListener struct { + exit chan struct{} + client naming_client.INamingClient + regConf *model.Registry + reg *NacosRegistry + wg sync.WaitGroup + addr string + adapterListener common2.RegistryEventListener + appInfoMap map[string]*applicationInfo +} + +// newNacosAppListener returns a new nacosAppListener with pre-defined path according to the registered type. +func newNacosAppListener(client naming_client.INamingClient, reg *NacosRegistry, regConf *model.Registry, adapterListener common2.RegistryEventListener) registry.Listener { + return &nacosAppListener{ + exit: make(chan struct{}), + client: client, + regConf: regConf, + reg: reg, + addr: regConf.Address, + adapterListener: adapterListener, + appInfoMap: map[string]*applicationInfo{}, + } +} + +func (n *nacosAppListener) Close() { + close(n.exit) + n.wg.Wait() +} + +func (n *nacosAppListener) WatchAndHandle() { + n.wg.Add(1) + go n.watch() +} + +func (n *nacosAppListener) watch() { + defer n.wg.Done() + var ( + failTimes int64 = 0 + delayTimer = time.NewTimer(ConnDelay * time.Duration(failTimes)) + ) + defer delayTimer.Stop() + for { + serviceList, err := n.client.GetAllServicesInfo(vo.GetAllServiceInfoParam{ + GroupName: n.regConf.Group, + NameSpace: n.regConf.Namespace, + PageSize: 100, + }) + if err != nil { + failTimes++ + logger.Infof("watching nacos interface with error{%v}", err) + // Exit the watch if root node is in error + // TODO: do not use zookeeper error + if err == zookeeper.ErrNilNode { + logger.Errorf("watching nacos services got errNilNode,so exit listen") + return + } + if failTimes > MaxFailTimes { + logger.Errorf("Error happens on nacos exceed max fail times: %s,so exit listen", MaxFailTimes) + return + } + delayTimer.Reset(ConnDelay * time.Duration(failTimes)) + <-delayTimer.C + continue + } + failTimes = 0 + if err := n.updateServiceList(serviceList.Doms); err != nil { + logger.Errorf("update service list failed %s", err) + } + time.Sleep(time.Second * 5) + } +} + +type applicationInfo struct { + appName string + listener *appServiceListener +} + +func (a *applicationInfo) String() string { + return a.appName +} + +func fromServiceKey(serviceKey string) *applicationInfo { + // if serviceKey contains ":" means it is a interface registry + // we should ignore it + if strings.Contains(serviceKey, ":") { + return nil + } + return &applicationInfo{ + appName: serviceKey, + } +} + +func (n *nacosAppListener) updateServiceList(serviceList []string) error { + // add new service info and watch + newServiceMap := make(map[string]bool) + + for _, v := range serviceList { + appInfo := fromServiceKey(v) + if appInfo == nil { + // ignore interface registry + continue + } + key := appInfo.String() + newServiceMap[key] = true + if _, ok := n.appInfoMap[key]; !ok { + url, _ := dubboCommon.NewURL("mock://localhost:8848") + url.SetParam(constant.ApplicationKey, appInfo.appName) + l := newNacosAppSrvListener(n.client, n.adapterListener) + l.wg.Add(1) + + appInfo.listener = l + n.appInfoMap[key] = appInfo + + // subscribe go routine + go func(a *applicationInfo) { Review Comment: yes, the coroutine is not necessary, i will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
