Re: [PR] [3.3] Upgraded netty3 to 3.10.6.Final, netty4 to 4.1.119.Final [dubbo]

[via GitHub]

zrlw commented on code in PR #15193:
URL: https://github.com/apache/dubbo/pull/15193#discussion_r1978504625


##########
dubbo-dependencies-bom/pom.xml:
##########
@@ -316,7 +316,7 @@
         <scope>test</scope>
       </dependency>
       <dependency>
-        <groupId>org.jboss.netty</groupId>

Review Comment:
   i see. i think the reason that moving netty to netty-all since netty 
4.0.0.Final is to allow using them together in one application, there are no 
conflicts between io.netty:netty and io.netty:netty-all, 
   https://mvnrepository.com/artifact/io.netty/netty
   
![netty](https://github.com/user-attachments/assets/c209e788-055b-4d00-8952-0031717cc53d)
   https://mvnrepository.com/artifact/io.netty/netty-all
   
![netty-all](https://github.com/user-attachments/assets/d55fb197-1a0f-4e97-8f5b-33d10b9a24d2)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org