Nexusrex18 opened a new pull request, #2795: URL: https://github.com/apache/dubbo-go/pull/2795
Fix multiple issues in dubbogo-cli when interacting with ZooKeeper as a registry. This PR resolves a panic caused by invalid URL parsing (`://dubbo-go-samples-configcenter-zookeeper-client`), addresses a "too many colons" error when initializing the ZooKeeper client, and improves error handling for cases where ZooKeeper data is missing (e.g., `/dubbo` node not found). It also updates the tool to fetch URL data from node content rather than node names, ensuring correct method extraction. Key changes: - `cmd/show.go`: Added input validation, passed raw host addresses, and handled errors gracefully with user-friendly output. - `metadata/zookeeper/zookeeper.go`: Fixed URL parsing by using node content, stripped schemes from addresses, and improved robustness. Tested with: - Empty ZooKeeper: Displays "No data available" without crashing. - Populated ZooKeeper: Correctly lists interfaces and methods (e.g., `org.apache.dubbo.sample.UserProvider` with `GetUser, UpdateUser`). Fixes: #2681 Signed-off-by: Nexusrex18 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
