cjphaha commented on code in PR #2810:
URL: https://github.com/apache/dubbo-go/pull/2810#discussion_r2008796687
##########
protocol/triple/triple_protocol/handler_stream_compat.go:
##########
@@ -92,6 +92,10 @@ func generateCompatStreamHandlerFunc(
interceptor Interceptor,
) StreamingHandlerFunc {
implementation := func(ctx context.Context, conn StreamingHandlerConn)
error {
+ ctx = metadata.NewIncomingContext(ctx,
metadata.MD(conn.ExportableHeader()))
+ // staticcheck error: SA1029. Stub code generated by
protoc-gen-go-triple makes use of "XXX_TRIPLE_GO_INTERFACE_NAME" directly
+ //nolint:staticcheck
+ ctx = context.WithValue(ctx, "XXX_TRIPLE_GO_INTERFACE_NAME",
procedure)
Review Comment:
Code format suggestion: Can this **XXX_TRIPLE_GO_INTERFACE_NAME** be defined
in the common/constants directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
