Nexusrex18 commented on code in PR #2812: URL: https://github.com/apache/dubbo-go/pull/2812#discussion_r2014838399
########## common/url.go: ########## @@ -779,6 +779,14 @@ func (c *URL) MergeURL(anotherUrl *URL) *URL { // After Clone, it is a new URL that there is no thread safe issue. mergedURL := c.Clone() params := mergedURL.GetParams() + if params == nil { + mergedURL.paramsLock.Lock() Review Comment: Yes i have done the changes but getting this drafter error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org