oxsean commented on code in PR #15292:
URL: https://github.com/apache/dubbo/pull/15292#discussion_r2024192410


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/mapping/DefaultRequestMappingRegistry.java:
##########
@@ -130,6 +130,12 @@ public void register(Invoker<?> invoker) {
                 consumer.accept((methods) -> {
                     Method method = methods.get(0);
                     MethodDescriptor md = sd.getMethod(method.getName(), 
method.getParameterTypes());
+                    if (md == null) {
+                        String originMethodName = method.getName();
+                        String upperMethod =

Review Comment:
   It's better to add a length check, otherwise the method will fail with only 
one letter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to