AlbumenJ commented on code in PR #15338:
URL: https://github.com/apache/dubbo/pull/15338#discussion_r2076650834
##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java:
##########
@@ -1242,14 +1242,17 @@ public static byte decodeHexByte(CharSequence s, int
pos) {
}
/**
- * Create the common-delimited {@link String} by one or more {@link
String} members
+ * Creates a comma-delimited string from one or more string values.
*
- * @param one one {@link String}
- * @param others others {@link String}
- * @return <code>null</code> if <code>one</code> or <code>others</code> is
<code>null</code>
+ * @param one the first string value
+ * @param others additional string values
+ * @return a combined comma-delimited string, or <code>null</code> if
{@code one} or {@code others} is {@code null}
* @since 2.7.8
*/
public static String toCommaDelimitedString(String one, String... others) {
+ if (one == null || others == null) {
+ return null;
Review Comment:
if one != null && others == null
should return one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
