AlexStocks commented on code in PR #659:
URL: https://github.com/apache/dubbo-go-pixiu/pull/659#discussion_r2083095429
##########
pkg/filter/tokenizer/tokenizer.go:
##########
@@ -174,37 +175,44 @@ func newTeeReadCloser(r io.ReadCloser, w io.Writer)
*teeReadCloser {
func (t *teeReadCloser) Read(p []byte) (n int, err error) {
n, err = t.reader.Read(p)
- if n <= 0 {
+ if n <= 0 || err != nil {
return
}
- nw, ew := t.writer.Write(p[:n])
- if ew != nil {
- logger.Errorf(LoggerFmt+"Error writing to tee writer: %v", ew)
+ nw, err := t.writer.Write(p[:n])
+ if err != nil {
+ logger.Errorf(LoggerFmt+"Error writing to tee writer: %v", err)
+ return
}
if nw != n {
logger.Errorf(LoggerFmt+"Short write to tee writer: %d/%d", nw,
n)
+ //err = fmt.Errorf("short write to tee writer: %d/%d", nw, n)
}
- return
+ return n, nil
}
func (t *teeReadCloser) Close() (err error) {
+ var closerErr error
Review Comment:
改成酱紫
var (
closerErr error
writerErr error
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
