Jyyjy commented on issue #359: URL: https://github.com/apache/flagon-useralejs/issues/359#issuecomment-1681081778
> I have begun to implement a json schema with test cases [here](https://github.com/apache/flagon-useralejs/commit/5fea1aea062068af9db193b85420a58098f1441e). > > There is an issue with "load" type logs. Load logs are [created ](https://github.com/apache/flagon-useralejs/blob/9c4cca7cc728ecf00a4b78c826ec5d25e7b8a87c/src/main.js#L70)via `packageCustomLog()`, but the "logType" field is overwritten to be "raw". The schema I've created requires certain fields for raw logs with the expectation that raw logs are created with `packageLog()`. > > Instead of loosening the schema to fit raw load logs, I think it makes more sense to make load logs "custom". And perhaps then the raw/custom dichotomy should be renamed to something like event/nonevent? The raw/custom names imply that the base userale script only produces raw logs, and any modifications will only produce custom logs, but that is not the case. > > Any thoughts/objections? Here's the beginnings of what I explained above. I figure these are pretty major changes so they would go into a 3.0 release. I also think it would make sense to rework browser logs so that they use the same functions and fit the same schema. https://github.com/UMD-ARLIS/incubator-flagon-useralejs/tree/schema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
