EandrewJones commented on code in PR #42: URL: https://github.com/apache/flagon/pull/42#discussion_r1438319285
########## docker/logstash/8.11.1/templates/userale.json: ########## Review Comment: Let's use the legacy template for now. > Also, not related to this PR, but is there a reason why each elk stack version is kept in source instead of keeping the latest and relying on git? The reason is purely convention. But I agree it makes more sense to switch to using git tags for each version and having having the tip of the branch only show latest. However, this would require quite a bit of GIT wrangling for a low value add at this point. We can add your two asks as tickets in the backlog: 1. migrating the logstash template to the composable template 2. Switch elk stack versioning to git tags, showing only the latest in source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
