EandrewJones commented on PR #33: URL: https://github.com/apache/flagon-distill/pull/33#issuecomment-1971360593
The final change here is to move this functionality out of the `utils/crud` and into it's own, new module called `sessions`. The session object (dict) is a new unit of observation in distill. The helpers you wrote are all specific to it. As such, we should give them their own directory and files, i.e. `distill/sessions/...` To be consistent with the rest of the codebase, the Session object we create really should be it's own class, but for now this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
