Jyyjy commented on code in PR #425: URL: https://github.com/apache/flagon-useralejs/pull/425#discussion_r1537538810
########## README.md: ########## @@ -301,11 +301,22 @@ you will need to rebuild the UserALE.js script (and run tests). To (re)build UserALE.js: ``` +make build +``` +Alternatively, +``` +npm install npm run build ``` To run UserALE.js unit tests: ``` +make test +``` +Alternatively, +``` +npm install +npm run build Review Comment: No need to build before testing, `npm run test` will clean and rebuild ########## makefile: ########## @@ -0,0 +1,9 @@ +.PHONY: build test + +build: + npm install + npm run build +test: + npm install + npm run build Review Comment: Same thing here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
