EandrewJones commented on PR #452: URL: https://github.com/apache/flagon-useralejs/pull/452#issuecomment-2103411301
@rc10house I just noticed a few things. 1. You're doing this work directly on your master and merging to master. 2. You've combined multiple tickets into a single PR. Please do the following: 1. Revoke this PR. 2. Create a new branch for each issue you are working on and include the issue number in the branch title, e.g. `399-auth-headers-ignored-send-on-close` 3. Cherry pick the correct commits from your master into each branch, respectively. 4. Roll back your master to match the REMOTE master 5. Squash the commits for each issue-branch into a single commit. 6. Create separate PRs for each of the issue-branches, and reference the issues in the PR text via `#<issue-number-here>`. This will keep the history clean and maintain a one-one mapping between commits and issues. Very important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
