Jyyjy commented on code in PR #480:
URL: https://github.com/apache/flagon-useralejs/pull/480#discussion_r1684861797
##########
package.json:
##########
@@ -16,6 +16,7 @@
"test": "npm run test:unit && npm run test:e2e",
"test:unit": "jest -c ./test/unit/jest.config.ts",
"test:e2e": "playwright test -c ./test/e2e/playwright.config.ts",
+ "pretest:e2e": "rm -rf ./test/e2e/chromeData/*",
"posttest:e2e": "rm -rf ./test/e2e/chromeData/*",
Review Comment:
Added because when a test fails playwright starts a server for the results
that needs an interrupt signal to stop. That interrupt signal prevents the post
command from cleaning up.
But on second thought, I'll just create an explicit script to cleanup that
runs regardless of the main scripts completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
