Jyyjy commented on code in PR #489:
URL: https://github.com/apache/flagon-useralejs/pull/489#discussion_r1722299825
##########
example/test-client.ts:
##########
Review Comment:
Can you move the testing logic to test/ and add the test to at least one of
the frameworks (Jest for unit/, Playwright for e2e/). e2e may be easier,
because it uses a real(ish) browser and allows control over the receiving
server in playwright.config.ts.
##########
src/main.ts:
##########
@@ -48,7 +49,7 @@ config.update({
useraleVersion: userAleVersion,
});
initPackager(logs, config);
-
+getWebsocketsEnabled(config);
Review Comment:
Move this call to getInitialSettings()
##########
src/main.ts:
##########
Review Comment:
Move all the changes in this file to getInitialSettings.ts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
