kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#issuecomment-338719748 Yes, importing FluoConfiguration with shift O in eclipse did that, forgot to run impsort and commit again. That plugin is so boss I've been recommending it on Log4J2 and Nutch. On Oct 23, 2017 8:35 AM, "Keith Turner" <[email protected]> wrote: > *@keith-turner* approved this pull request. > > These changes look good, just need to run mvn compile to format and > organize imports. I was able to successfully run mvn verify locally. I > need to get that travis timeout issue figured out. > ------------------------------ > > In modules/core/src/main/java/org/apache/fluo/core/impl/ > FluoConfigurationImpl.java > <https://github.com/apache/fluo/pull/951#discussion_r146304645>: > > > @@ -143,6 +143,45 @@ public static long getTxIfoCacheTimeout(FluoConfiguration conf, TimeUnit tu) { > } > return tu.convert(millis, TimeUnit.MILLISECONDS); > } > + public static final String VISIBILITY_CACHE_SIZE = FLUO_IMPL_PREFIX + ".visibility.cache.size.mb"; > + public static final long VISIBILITY_CACHE_SIZE_DEFAULT = 10000000; > > I think in java 7 or 8 the ability to add underscores in numbers was > added. So could change this to 10_000_000 to make it a bit more readable. > ------------------------------ > > In modules/core/src/main/java/org/apache/fluo/core/impl/ > VisibilityCache.java > <https://github.com/apache/fluo/pull/951#discussion_r146304929>: > > > import org.apache.fluo.api.data.Bytes; > import org.apache.fluo.api.data.Column; > import org.apache.fluo.core.util.ByteUtil; > > +import com.google.common.cache.Cache; > > When I ran mvn compile locally it reorganized these imports. > > ? > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fluo/pull/951#pullrequestreview-71227153>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/Acg-LGnTxjyEx9tC-X-QMRlzY14Mh9b1ks5svLJFgaJpZM4QBwap> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
