cjmctague commented on a change in pull request #953: fixes #917 Added read locks URL: https://github.com/apache/fluo/pull/953#discussion_r147714377
########## File path: modules/accumulo/src/main/java/org/apache/fluo/accumulo/iterators/OpenReadLockIterator.java ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.fluo.accumulo.iterators; + +import java.io.IOException; +import java.util.Collection; +import java.util.Map; + +import org.apache.accumulo.core.data.ByteSequence; +import org.apache.accumulo.core.data.Key; +import org.apache.accumulo.core.data.PartialKey; +import org.apache.accumulo.core.data.Range; +import org.apache.accumulo.core.data.Value; +import org.apache.accumulo.core.iterators.IteratorEnvironment; +import org.apache.accumulo.core.iterators.SortedKeyValueIterator; +import org.apache.fluo.accumulo.util.ColumnConstants; +import org.apache.fluo.accumulo.util.ReadLockUtil; + +import static org.apache.fluo.accumulo.util.ColumnConstants.ACK_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.DATA_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.DEL_LOCK_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.LOCK_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.RLOCK_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.TIMESTAMP_MASK; +import static org.apache.fluo.accumulo.util.ColumnConstants.TX_DONE_PREFIX; +import static org.apache.fluo.accumulo.util.ColumnConstants.WRITE_PREFIX; + +public class OpenReadLockIterator implements SortedKeyValueIterator<Key, Value> { + + private TimestampSkippingIterator source; + + private Key lastDelete; + + private void findTop() throws IOException { + while (source.hasTop()) { + + long colType = source.getTopKey().getTimestamp() & ColumnConstants.PREFIX_MASK; + + if (colType == TX_DONE_PREFIX || colType == WRITE_PREFIX || colType == DEL_LOCK_PREFIX) { + source.skipToPrefix(source.getTopKey(), RLOCK_PREFIX); + continue; + } else if (colType == RLOCK_PREFIX) { + if (ReadLockUtil.isDelete(source.getTopKey())) { + lastDelete.set(source.getTopKey()); + } else { + if (lastDelete.equals(source.getTopKey(), PartialKey.ROW_COLFAM_COLQUAL_COLVIS)) { + long ts1 = ReadLockUtil.decodeTs(source.getTopKey().getTimestamp() & TIMESTAMP_MASK); + long ts2 = ReadLockUtil.decodeTs(lastDelete.getTimestamp() & TIMESTAMP_MASK); + + if (ts1 != ts2) { + // found a read lock that is not suppressed by a delete read lock entry + return; + } + } else { + // found a read lock that is not suppressed by a delete read lock entry + return; + } + } + source.next(); + continue; + } else if (colType == DATA_PREFIX || colType == LOCK_PREFIX || colType == ACK_PREFIX) { + source.skipColumn(source.getTopKey()); + continue; + } else { + throw new IllegalArgumentException("Uknown column type " + source.getTopKey()); Review comment: Unknown Column Type ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
