kpm1985 commented on issue #963: Fix for FLUO-793 Modify ITs to use JUnits timeout rule URL: https://github.com/apache/fluo/pull/963#issuecomment-340830712 Missed it thank you. On Oct 31, 2017 9:33 AM, "Keith Turner" <[email protected]> wrote: > *@keith-turner* commented on this pull request. > ------------------------------ > > In modules/integration/src/test/java/org/apache/fluo/integration/impl/ > StochasticBankIT.java > <https://github.com/apache/fluo/pull/963#discussion_r148052916>: > > > @@ -53,8 +53,8 @@ > * sum of all money in the bank should be the same, therefore the average should not vary. > */ > public class StochasticBankIT extends ITBaseImpl { > - //@Rule > - //public Timeout globalTimeout = Timeout.seconds(120); > + @Rule > + public Timeout globalTimeout = Timeout.seconds(120); > > Why not call getTestTimeout() here? > > ? > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fluo/pull/963#pullrequestreview-73237292>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/Acg-LOf_GTTDbXmHhUXdrTgrTiviTHpoks5sx0vxgaJpZM4QJ0xo> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
