ctubbsii commented on a change in pull request #966: fluo-env.sh now supports
FLUO_JAVA_OPTS set in environment
URL: https://github.com/apache/fluo/pull/966#discussion_r148972579
##########
File path: modules/distribution/src/main/config/fluo-env.sh
##########
@@ -35,7 +35,9 @@ export
FLUO_CONN_PROPS="${FLUO_CONN_PROPS:-${conf}/fluo-conn.properties}"
## Fluo log4j configuration
export FLUO_LOG4J_CONFIG="${FLUO_LOG4J_CONFIG:-${conf}/log4j.properties}"
## Java options for Fluo command
-JAVA_OPTS=("-Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}")
+##PREPENDING JAVA_OPTS WITH FLUO_JAVA_OPTS ENVIRONMENT VARIABLE
+JAVA_OPTS=("$FLUO_JAVA_OPTS -Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}")
Review comment:
This variable is an array\*. Each element in the array should be quoted.
\* It's not clear to me that this is used consistently as an array later,
but at least here, it's an array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
